philip/mythic.nz
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

1099 Make a 404 page for the marketing site #4

Merged
laney-delaney-slaney merged 6 commits from 1099-create-404-page into main 2023-02-10 13:41:30 +13:00
Conversation 5 Commits 6 Files changed 4 +170 -1
laney-delaney-slaney commented 2023-02-09 09:42:11 +13:00 (Migrated from github.com)
Copy link
No description provided.
netlify[bot] commented 2023-02-09 09:42:16 +13:00 (Migrated from github.com)
Copy link

Deploy Preview for mythic-c4dc9a ready!

Name Link
Latest commit 72d7e317ea
Latest deploy log https://app.netlify.com/sites/mythic-c4dc9a/deploys/63e591b0e8ee730008385c11
Deploy Preview https://deploy-preview-4--mythic-c4dc9a.netlify.app/404
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

### <span aria-hidden="true">✅</span> Deploy Preview for *mythic-c4dc9a* ready! | Name | Link | |:-:|------------------------| |<span aria-hidden="true">🔨</span> Latest commit | 72d7e317ea962a9a4bc4891b02e2964100d41baa | |<span aria-hidden="true">🔍</span> Latest deploy log | https://app.netlify.com/sites/mythic-c4dc9a/deploys/63e591b0e8ee730008385c11 | |<span aria-hidden="true">😎</span> Deploy Preview | [https://deploy-preview-4--mythic-c4dc9a.netlify.app/404](https://deploy-preview-4--mythic-c4dc9a.netlify.app/404) | |<span aria-hidden="true">📱</span> Preview on mobile | <details><summary> Toggle QR Code... </summary><br /><br />![QR Code](https://app.netlify.com/qr-code/eyJ0eXAiOiJKV1QiLCJhbGciOiJIUzI1NiJ9.eyJ1cmwiOiJodHRwczovL2RlcGxveS1wcmV2aWV3LTQtLW15dGhpYy1jNGRjOWEubmV0bGlmeS5hcHAifQ.TNokhNim9o3qpHMIeYvvsqenmPYQCKHKOm1GUDhvAsU)<br /><br />_Use your smartphone camera to open QR code link._</details> | --- _To edit notification comments on pull requests, go to your [Netlify site settings](https://app.netlify.com/sites/mythic-c4dc9a/settings/deploys#deploy-notifications)._
philiprenich commented 2023-02-09 13:02:07 +13:00 (Migrated from github.com)
Copy link

image

I take it back, I think the mascot can be on top for mobile, just maybe a little smaller and adjusting white space.

Mascot on the right for the wide screen version.

![image](https://user-images.githubusercontent.com/635088/217679309-8b18db15-ecf4-4ab8-807a-d8c3043f4830.png) I take it back, I think the mascot can be on top for mobile, just maybe a little smaller and adjusting white space. Mascot on the right for the wide screen version.
philiprenich (Migrated from github.com) requested changes 2023-02-09 13:20:58 +13:00
.eleventy.js
philiprenich (Migrated from github.com) commented 2023-02-09 13:03:31 +13:00
Copy link

Should we remove this since Netlify handles the 404 mapping? In dev we can just hit the page directly.

Should we remove this since Netlify handles the 404 mapping? In dev we can just hit the page directly.
src/404.html
philiprenich (Migrated from github.com) commented 2023-02-09 13:04:51 +13:00
Copy link
      Are you lost, Adventurer?
```suggestion Are you lost, Adventurer? ```
philiprenich (Migrated from github.com) commented 2023-02-09 13:05:23 +13:00
Copy link
      Maybe we can help you find your way.
```suggestion Maybe we can help you find your way. ```
philiprenich (Migrated from github.com) commented 2023-02-09 13:06:53 +13:00
Copy link

Flipping the phrasing around to put the link nearer the start and have a more active voice.

      <a href="https://app.mythic.nz/">Visit the dashboard</a> to get started using the Mythic editor.
Flipping the phrasing around to put the link nearer the start and have a more active voice. ```suggestion <a href="https://app.mythic.nz/">Visit the dashboard</a> to get started using the Mythic editor. ```
philiprenich (Migrated from github.com) commented 2023-02-09 13:07:49 +13:00
Copy link
      Need a hand? Our <a href="https://mythic.nz/help">help scrolls</a> have information on how to

fyi help has moved to the marketing site

```suggestion Need a hand? Our <a href="https://mythic.nz/help">help scrolls</a> have information on how to ``` fyi help has moved to the marketing site
src/404.html
@ -0,0 +20,4 @@
<h2>
Maybe we can help you find your way.
</h2>
<p>
philiprenich (Migrated from github.com) commented 2023-02-09 13:10:11 +13:00
Copy link

This second line might be nice as an h2

This second line might be nice as an `h2`
src/_includes/banner-404.html
philiprenich (Migrated from github.com) commented 2023-02-09 13:20:44 +13:00
Copy link

Let's remove the aria-hidden in this case. I think it's nice to have this text available to screen readers. On the other pages, the alt text is blank so the attribute makes more sense.

As an aside though, it looks like aria-hidden is not a true boolean attribute; that is, it needs to be set to "true". Its presence alone doesn't remove it from the accessibility api, at least for MacOS VoiceOver. So the other pages could be updated to fix that. TBH, I could be swayed to add in an alt text to the other dragon images just to give a little bit of flavour to non-sighted users.

Let's remove the `aria-hidden` in this case. I think it's nice to have this text available to screen readers. On the other pages, the alt text is blank so the attribute makes more sense. As an aside though, it looks like `aria-hidden` is not a true boolean attribute; that is, it needs to be set to "true". Its presence alone doesn't remove it from the accessibility api, at least for MacOS VoiceOver. So the other pages could be updated to fix that. TBH, I could be swayed to add in an alt text to the other dragon images just to give a little bit of flavour to non-sighted users.
philiprenich (Migrated from github.com) requested changes 2023-02-09 16:24:12 +13:00
src/404.html
philiprenich (Migrated from github.com) commented 2023-02-09 16:22:18 +13:00
Copy link

Remove this, it's going into the meta tags.

Remove this, it's going into the meta tags.
philiprenich (Migrated from github.com) commented 2023-02-09 16:22:47 +13:00
Copy link

Maybe "Page not found"?

Maybe "Page not found"?
philiprenich (Migrated from github.com) commented 2023-02-09 16:23:31 +13:00
Copy link

I think we can get rid of this and just drop the text directly into the code.

I think we can get rid of this and just drop the text directly into the code.
src/404.html
@ -0,0 +2,4 @@
class: 404
title: "Page not found"
permalink: 404.html
---
philiprenich (Migrated from github.com) commented 2023-02-09 16:23:17 +13:00
Copy link

The permalink is needed so 11ty builds "404.html" not "/404/index.html". Netlify needs the former it looks like.

The permalink is needed so 11ty builds "404.html" not "/404/index.html". Netlify needs the former it looks like.
philiprenich (Migrated from github.com) approved these changes 2023-02-10 13:37:17 +13:00
Sign in to join this conversation.
Reviewers
No reviewers
philiprenich
Labels
Clear labels   
bug

Something isn't working

  
documentation

Improvements or additions to documentation

  
duplicate

This issue or pull request already exists

  
enhancement

New feature or request

  
good first issue

Good for newcomers

  
help wanted

Extra attention is needed

  
invalid

This doesn't seem right

  
question

Further information is requested

  
wontfix

This will not be worked on

No labels
bug
documentation
duplicate
enhancement
good first issue
help wanted
invalid
question
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: philip/mythic.nz#4
No description provided.
Delete branch "1099-create-404-page"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?